Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

matomo: remove unexpected files #1279

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

laalsaas
Copy link
Collaborator

@laalsaas laalsaas commented Feb 9, 2025

@flyingcircusio/release-managers

PL-133012

Release process

  • Created changelog entry using ./changelog.sh

PR release workflow (internal)

  • PR has internal ticket
  • internal issue ID (PL-…) part of branch name
  • internal issue ID mentioned in PR description text
  • ticket is on Platform agile board
  • ticket state set to Pull request ready
  • if ticket is more urgent than within the next few days, directly contact a member of the Platform team

Design notes

  • Provide a feature toggle if the change might need to be adjusted/reverted quickly depending on context. Consider whether the default should be on or off. Example: rate limiting.
  • All customer-facing features and (NixOS) options need to be discoverable from documentation. Add or update relevant documentation such that hosted and guided customers can understand it as well.

Security implications

  • Security requirements defined? (WHERE)
    • create a clean matomo installation
  • Security requirements tested? (EVIDENCE)
    • updated matomo from 4 to 5 on pntest00, integrity check is now clean except for issues in the upstream package

@laalsaas laalsaas force-pushed the PL-133012-matomo-remove-unexpected-files branch from a97e61e to 6b1e631 Compare February 10, 2025 15:43
@laalsaas laalsaas marked this pull request as ready for review February 13, 2025 20:00
@laalsaas laalsaas requested a review from dpausp February 13, 2025 20:01
@osnyx
Copy link
Member

osnyx commented Feb 19, 2025

stylistic remark: This does not just fix quoting, but also adds additional files to be cleaned up. The latter is not reflected in the commit message.
The next time you might want to split this into 2 commits, @laalsaas.

also add some more files

PL-133012
@osnyx osnyx force-pushed the PL-133012-matomo-remove-unexpected-files branch from 6b1e631 to 861912f Compare February 19, 2025 18:34
Copy link
Member

@osnyx osnyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the changelog myself.

@osnyx osnyx merged commit a54f820 into fc-24.05-dev Feb 19, 2025
1 check passed
@osnyx osnyx deleted the PL-133012-matomo-remove-unexpected-files branch February 19, 2025 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants